Hi Jon! Just thought I’d comment…

I had a couple of comments on your Dockerfiles: it seems the received wisdom is to use COPY rather than ADD, as the behaviour is more predictable. ADD tries to be helpful and can untar a *.tar.gz or copy from a URL. Apparently, it invalidates the cache used when building an image as well, which can lead to larger image sizes: https://nickjanetakis.com/blog/docker-tip-2-the-difference-between-copy-and-add-in-a-dockerile

The choice of echoing each line of the nginx config was…interesting. I’m not an expert by any means, but I think standard practice is to just write the file out and use COPY (or ADD) to copy it from the location alongside the Dockerfile to a location in the image. A lot easier to write out…